quote:

---

Originally posted by feline

The basic problem is that normally the header file and cpp files have the functions in a different order. As soon as this starts happening VA has no easy way of working out the correct position.

---

quote:

---

For now have you looked at VA Outline? It is designed to allow you to drag functions, re-ordering the file quickly and easily.

---

void func6();
void func2();
void called_by_func5(); // <-- I use create declaration on this function
void func5();
void func3();
void func4();
void func1();
void func7();

quote:

---

feline said:
Personally I often have my functions in a sensible order, but that is nothing like alphabetical. Private functions tend to come first. Worker functions before the functions that use them. Functions for a common purpose tend to be grouped together as well.

---

void func6();
// this is where VAX should place the new function (before func5())
void func5();
void func3();
void func4();
void func1();
void func2();
void called_by_func5(); // this is where VAX will place the new function (after func2())
void func7();

quote:

---

Originally posted by feline
In your example this is the "wrong" position. However I don't think there is a "right" position in your example.
[...]
This is the reason for the current behaviour, placing the function at the "end". It may be wrong, but at least it is simple to understand.

Lots of people want VA to do something more sensible, but no one seems to know what that more sensible thing is. case=12454 is a compromise.
[...]
I am open to good suggestions for a general solution

---

• Place implementation always at the end (as it is now).


• Use a simple rule to place the implementation.


• Make a complex analysis about the file is structure and guess the position.

• If both A and B are not found, place the implemtation of F at the end of the source file.


• If only one of A and B was found, place F after the implementation of A or before the implementation of B.


• If both A and B were found and B follows A in the implementation file, insert F between A and B.


• If both A and B were found and B does not follow A in the source file and dist(A,F) != dist(F,B), place F after A or before B, whatever is closer. Here dist(X,Y) is the number of statements (non-comments) between the declarations of X and Y.
  If dist(A,F) == dist(F,B), place F after A. This will still be correct in at least 50% of the cases :-)

quote:

---

Frunobulax I am wary of this, since any complex rule is hard to explain. When people start asking "why is VA doing X" how do I answer them?

---

quote:

---

Looking at the clauses I can immediately see two "problems". Firstly VA cannot tell which overload is which.

---

quote:

---

Secondly in point 3 you mention the case where the function order is reversed in the cpp file. But what happens when they are in the wrong order and there are 30 functions in between them?

---

quote:

---

Did you notice:

>> case=12454, which is referenced in this thread, has the title:

>> Create Implementation to place new code below the implementation of preceding function

This is only a simple rule, but it seems like a reasonable idea on paper.

---