All Forums  Visual Assist  Feature Requests  Change Signature on virtual functions

You must be registered to post a reply.
Click here to register.

Screensize: 640 x 480 800 x 600 1024 x 768 1280 x 1024 UserName: Password: Format: Font Andale Mono Arial Arial Black Book Antiqua Century Gothic Comic Sans MS Courier New Georgia Impact Lucida Console Script MT Bold Stencil Tahoma Times New Roman Trebuchet MS Verdana   Size 1 2 3 4 5 6   Color Black Blue Brown Green Red Violet Yellow Message: Forum code is on. Html is off. [quote][i]Originally posted by JohnCrenshaw[/i] [br]I recently did a Change Signature on a virtual function changing both the name and some other attributes. I was pleasantly surprised to find that the rename filtered down to all of the derived classes as well, however, the rest of the signature only changed for my base class. I'd like to make a case for changing the signature across the board, at least where class inheritance and the virtual keyword makes the functions effectively the same. 1. If a virtual function is refactored and remains virtual, it makes sense to change all of the equivalent functions in all derived classes. 2. The reason is that these are functionally the same, and calling the virtual function causes a call to the highest level override defined for the object. 3. If some (but not all) of the the signatures suddenly become different, the function that gets called in any given case has now changed because virtual only works if the signatures are the same. 4. This is bad because the ChangeSignature function should generally leave the code opperating exactly as it did before. (In fact a message is given warning about references not being changed because the user would expect all to work as before.) 5. The references problem for which a message is popped up will generally generate compiler errors/warnings because the function name and/or signature doesn't resolve to a valid symbol anymore, however, this virtual function problem causes neither errors nor warnings in most cases, because all declarations and symbols are just as valid as they were before, even though they are behaviorly different. The absence of warnings means that if a developer is not really on the ball, they could silently introduce major bugs. [/quote]   Check to include your profile signature. Check to subscribe to this topic.