All Forums  Visual Assist  Feature Requests  'Extract Method" - a suggestion for improvement

You must be registered to post a reply.
Click here to register.

Screensize: 640 x 480 800 x 600 1024 x 768 1280 x 1024 UserName: Password: Format: Font Andale Mono Arial Arial Black Book Antiqua Century Gothic Comic Sans MS Courier New Georgia Impact Lucida Console Script MT Bold Stencil Tahoma Times New Roman Trebuchet MS Verdana   Size 1 2 3 4 5 6   Color Black Blue Brown Green Red Violet Yellow Message: Forum code is on. Html is off. [quote][i]Originally posted by peterboulton[/i] [br]"Extract Method" is a brilliant options and increasingly useful now I need to go back over existing code and 'parallelize'. However, the way VAX determines which variables/objects need to be passed as arguments to the extracted function seems pretty simplistic. For example, say the block you are extracting uses a (utility) variable that was declared locally, but outside the selected block for extract method. If the code in the selected block modifies it then surely it may not need to be passed as an argument to the extracted function? For example, consider the following as part of the selection for method extraction: // Get target cell pCell=pRow->GetAt(col); .. get strCellText for the cells text pCell->SetText(strCelltext) In this case, pCell and strCellText need to only be local variables in the extracted method, yet VAX doesn't seem to have any way of identifying them and instead insists on passing them as arguments to the extracted method. I'd settle for just being able to edit the text in the 'Preview of method signature' on the 'Extract method' dialog box and for the signature to be whatever that box contains when I click 'OK' on the dialog. Or even better, compare the original contents with the revised contents and declare any arguments which were there in the generated signature but manually removed as local variables in the extracted method. I hope I've explained this clearly - it's very hard sometimes! Thanks. Pete [/quote]   Check to include your profile signature. Check to subscribe to this topic.