| Author |
 Topic  |
|
|
feline
Whole Tomato Software
United Kingdom
18939 Posts |
 Posted - Apr 25 2007 : 2:18:10 PM
|
From the 1554 thread:
quote:
Originally posted by AdyR
Looks like it could be good but I have had a couple of issues.
1. I dragged a non-class function, which was in the middle of the classes, to the bottom of the list and it disappeared. When I looked in the code it had been inserted inside the last function, just before the ending }. The last } was on the last line of the file. If I added a new line after the brace then the function is added after the last function.
2. I highlighted a block of non-class variables from the middle of the list to place them just before the top class methods branch and it left the last one of the variables behind. Any further attempts to move the remaining variable failed.
Also, could the constants have a branch rather than being in the root?
|
zen is the art of being at one with the two'ness |
|
|
feline
Whole Tomato Software
United Kingdom
18939 Posts |
Posted - Apr 25 2007 : 2:24:24 PM
|
Point 1, I am seeing the same problem when there is no blank line at the bottom of the file:
case=6209
Point 2, I have added the following code to a cpp file:
static void functionAboveVariables()
{
// empty function
}
static int nFoo1 = 0;
static int nFoo2 = 0;
static int nFoo3 = 0;
when I select the three variables in Live Outline and drag them to above the function all three are moved correctly. Is this similar to what you are doing? Or are you doing something different?
Constants into a branch, what happens when they are dotted through the file, so you have a couple of constants, 3 functions, then 2 more constants? |
zen is the art of being at one with the two'ness |
 |
|
|
AdyR
Ketchup Master
United Kingdom
75 Posts |
Posted - Apr 26 2007 : 07:37:36 AM
|
Point 2 is as you described. I will try to recreate the problem I found to see if I can locate the cause more precisely.
Constants into a branch: First I should say that constants was probably not the best choice of words as what I mean is file variables / constants that are declared outside any function. Basically all the items that currently appear loose in the root.
I envisage these branches would behave as the other branches do, e.g:
- Constants
clsid =
_tlid =
_wVerMajor = 1;
+ CClass methods
- Constants
bClassRegistered = FALSE;
+ CClass methods
Basically it would just allow the branch/s to be collapsed to hide all the noise and possibly make it easier to group them by dragging the branch?
|
Ady |
|
|
|
AdyR
Ketchup Master
United Kingdom
75 Posts |
Posted - Apr 26 2007 : 08:00:05 AM
|
Point 2 is caused by the way the comment is positioned in the file:
// *** AddExt: Type library support
// this is the uuid of the typelib itself
const GUID CDECL BASED_CODE _tlid =
// {5CAFAE83-EDD5-11D2-9CAA-FFCFC7E13737}
{ 0x5CAFAE83, 0xEDD5, 0x11D2, { 0x9c, 0xaa, 0xff, 0xcf, 0xc7, 0xe1, 0x37, 0x37 } };
const WORD _wVerMajor = 1;
const WORD _wVerMinor = 0; |
Ady |
Edited by - AdyR on Apr 26 2007 08:01:00 AM |
|
|
|
AdyR
Ketchup Master
United Kingdom
75 Posts |
Posted - Apr 26 2007 : 08:17:00 AM
|
I have also noticed that in a C file, all the functions appear in the root so it would be nice if they had a branch for File Methods.
The outline view is a nice feature that I have already found useful. |
Ady |
|
|
|
feline
Whole Tomato Software
United Kingdom
18939 Posts |
Posted - Apr 26 2007 : 09:39:59 AM
|
quote:
Originally posted by AdyR
Point 2 is caused by the way the comment is positioned in the file:
I am able to reproduce a problem. I am not sure if it is the problem you are seeing, but something is going wrong.
case=6232 |
zen is the art of being at one with the two'ness |
|
|
|
feline
Whole Tomato Software
United Kingdom
18939 Posts |
Posted - Apr 26 2007 : 09:48:30 AM
|
quote:
Originally posted by AdyR
Constants into a branch: First I should say that constants was probably not the best choice of words as what I mean is file variables / constants that are declared outside any function. Basically all the items that currently appear loose in the root.
Basically globals. Any variables with "file scope". Seems reasonable to me.
case=6233 |
zen is the art of being at one with the two'ness |
|
|
|
feline
Whole Tomato Software
United Kingdom
18939 Posts |
Posted - Apr 26 2007 : 09:50:37 AM
|
quote:
Originally posted by AdyR
I have also noticed that in a C file, all the functions appear in the root so it would be nice if they had a branch for File Methods.
The outline view is a nice feature that I have already found useful.
This one I am not so sure about. What is the benefit?
I can see why grouping constants / globals together makes sense, but why would you want a group of all non class member functions? |
zen is the art of being at one with the two'ness |
|
|
|
AdyR
Ketchup Master
United Kingdom
75 Posts |
Posted - Apr 26 2007 : 12:30:27 PM
|
quote:
This one I am not so sure about. What is the benefit?
I can see why grouping constants / globals together makes sense, but why would you want a group of all non class member functions?
I am thinking that when all the branches are collapsed you get a clean view of the groups which makes it easier to focus on a specific section and move things around to tidy up so that groups are not split. At the moment there is a lot in the root that makes it hard to spot out-of-place items. What I would like to do is use it to tidy up old files so they are organised something like:
+ #includes
+ #defines
+ File Variables
+ File Methods
+ CClass1 Methods
+ CClass2 Methods
I guess you can see why my house always appears tidy but woe-betide anyone than opens a cupboard 
Cheers. |
Ady |
|
|
|
feline
Whole Tomato Software
United Kingdom
18939 Posts |
Posted - Apr 26 2007 : 12:41:53 PM
|
This makes sense, but I am concerned about encouraging the idea:
+ #includes
+ #defines
+ File Variables
+ File Methods
- Classes
|+ CClass1 Methods
|+ CClass2 Methods
It makes sense to leave the functions showing, since this is normally the bulk of the file, and is what you are focussing on. |
zen is the art of being at one with the two'ness |
|
|
|
support
Whole Tomato Software
5566 Posts |
Posted - May 31 2007 : 12:10:02 AM
|
| case=6209, case=6232, case=6233 fixed in build 1557 |
Edited by - support on May 31 2007 12:40:44 AM |
|
|
|
AdyR
Ketchup Master
United Kingdom
75 Posts |
Posted - Jun 04 2007 : 1:31:27 PM
|
quote:
Originally posted by support
case=6209, case=6232, case=6233 fixed in build 1557
Looks good. It has made the job of tidying up some of the old C files so much easier.
Thanks guys. |
Ady |
|
|
| |
Topic |
|
bug reports from AdyR
