I used change signature to change the name of a function parameter (in a cpp file). I had a similar string in a comment, in my previous function body, and VAX renamed it also.
It is very important to disable find references' find comments and strings feature when change signature invokes rename (which invokes the find references)
Rename should only search inside affected function's body and comments prior to function header.
But one thing is a little problematic: while rename populate a listbox with found comments, change signature's rename feature is working automatically. Automatically renaming comments is not a safe thing
Change signature should allways pop up the rename dialog before renaming, or when there are comments in the result at least. This idea is absolutely great in rename dialog!
Ps.: Maybe turning off "comments rename" in change signature as a hotfix?
We are looking for a quick fix for these reasons and leaning towards the rename dialog appearing longer term.
Defining the "attached" comment can get interesting though, I thought up some interesting test cases when testing rename and comments. Overloaded functions was a good way to produce interesting effects.
VAX 1616: Change Signature renames comments
Posted - Nov 14 2007 : 09:43:40 AM
