quote:

---

Originally posted by rhummer

Move Implementation uses the VA Snippet entry "Refactor Create Implementation" Tweak that entry to 'fix' the spaces in the parameter list.

---

quote:

---

Originally posted by rhummer

Tweaking the VA Snippet only fixes the parameter list. All you have to do is tweak the formatting around the parentheses..

I assume the other issue is a bug, but I'll let feline answer that. :)

---

quote:

---

Originally posted by feline

The snippet "Refactor Create Implementation" is used for "Move Implementation to Source File", "Change Signature" and "Create Implementation"

While a prototype does exist for two of these, we cannot simply preserve the white space when running Change Signature. This is a known problem, but it is a hard problem to solve since it has so many edge cases.

So instead VA applies the white space given in the snippet for the start and end of the parameter list when running these commands, on the theory that consistency is good. I get the impression most of our users want all of their code formatted the same way, which the current system produces.

Also sometimes Move Implementation to Source File has to change the parameter list, default parameters are a good example of this, which further complicates matters.


Loosing the custom formatting inside the function body does look like a bug to me:

case=10385

---

void foo(  int param1,
           int param2
           )
{
}

class CTestFormatting
{
    void parametersAreWrappedAndAllined(int nParam1,
                                        int nParam2,
                                        int nParam3);
};

void CTestFormatting::parametersAreWrappedAndAllined(int nParam1,
                                    int nParam2,
                                    int nParam3)
{
}

quote:

---

Originally posted by feline

You can certainly do that, and quite a bit more easily. The problem with this approach is that you then need to keep all copies of the TPL files in sync, making any changes you want to other, more "stable" snippets in all files.

Using some form of script you can update several snippets in a single pass, with a single command line parameter. The script I posted was simply an interesting experiment, I wanted to see how well I could do something like that in VBScript I can see various ways to improve it, if I was using it heavily.

The different approaches have different benefits and drawbacks. It is just a case of finding the approach that suits you best.

---

quote:

---

Originally posted by feline

I need to use VBScript to program and control our automated testing tool. As a language its not so terrible when you get past the screaming and the urge to throw things at the computer

A simple batch file to rename the TPL files might be the best solution, if you want to easily swap between files. This was my original suggestion to the other user, but they did not like having to keep the files in sync by hand. A diff program will do this just fine, but it is an extra step you need to take.

---