| Author |
 Topic  |
|
|
SvenR
Tomato Guru
110 Posts |
 Posted - Apr 09 2008 : 04:36:10 AM
|
Just downloaded 1632 and noticed, that it looks different than 1626. I made two screen shots, to demonstrate the differences I set the colors to:
Blue - Classes, structures, typedefs
C000C0 - Variables
Gray - Preprocessor macros
Red - Methods
You will see, that structures (NMHEADER, HDITEM) in 1632 are displayed as macros. PostMessage as a method of CWnd is displayed as macro too, probably because it is defined as macro for PostMessageA/W in winuser.h.
The listbox in 1632 is shown with an ugly dialog frame. Please restore the old 3D frame (at least optionally). |
Windows 11 x64, VS 2022, VaX 10.9.2530 |
|
|
rhummer
Tomato Guru
USA
527 Posts |
Posted - Apr 09 2008 : 10:12:16 AM
|
I prefer how the VA X listboxes now adhere to the rest of the UI under Vista, UI Consistency is very important IMO. VA X is doing nothing wrong if you fire up VS under Vista with out VA X enabled you will notice the IDE also produces listboxes that look like that.
I also suspect they might have upgraded to VS2008 which includes Vista UI enhancements in the Windows SDK, which I would assume gives the listboxes that look and feel, but that just me guessing. :) |
Tools Engineer - Raven Software
VS2005 SP2/VS2008 SP1 - VAX <LATEST> - Win 7 x64
|
 |
|
|
SvenR
Tomato Guru
110 Posts |
Posted - Apr 09 2008 : 10:23:17 AM
|
quote:
Originally posted by rhummer
VA X is doing nothing wrong if you fire up VS under Vista with out VA X enabled you will notice the IDE also produces listboxes that look like that.
Oh dear! Please please feline, add an hidden option to get back the slim listboxes. I guess it's only a matter of window styles.  |
Windows 11 x64, VS 2022, VaX 10.9.2530 |
Edited by - SvenR on Apr 09 2008 10:24:01 AM |
|
|
|
feline
Whole Tomato Software
United Kingdom
19022 Posts |
Posted - Apr 09 2008 : 2:04:19 PM
|
| Your screen shots refuse to load for me, making it a little difficult to comment. Which OS are you using? |
zen is the art of being at one with the two'ness |
|
|
|
rhummer
Tomato Guru
USA
527 Posts |
Posted - Apr 09 2008 : 2:37:38 PM
|
Feline here is a screenshot of what he means, this is under Vista.
 |
Tools Engineer - Raven Software
VS2005 SP2/VS2008 SP1 - VAX <LATEST> - Win 7 x64
|
|
|
|
SvenR
Tomato Guru
110 Posts |
Posted - Apr 09 2008 : 5:41:37 PM
|
quote:
Originally posted by feline
Your screen shots refuse to load for me, making it a little difficult to comment. Which OS are you using?
I'm using Vista. I sent you the screen shots by e-mail. |
Windows 11 x64, VS 2022, VaX 10.9.2530 |
|
|
|
feline
Whole Tomato Software
United Kingdom
19022 Posts |
Posted - Apr 10 2008 : 2:57:00 PM
|
I have the email. The listbox borders, this is a Vista specific effect. As rhummer says they match the listboxes you get under Vista with VA disabled. I am not sure what to say here. Personally I am not a great fan of them, but I am not a great fan of the Vista look and feel either, so that does not mean much.
I will ask about this.
The colouring of "PostMessage", what do you see in the definition field when you place the caret into PostMessage? I am seeing:
#define PostMessage PostMessageA
under both VA 1626 and VA 1632. Since this is a macro, it makes sense that it is now being coloured as a macro. It is coloured as a function for me in VA 1626, but shown as a macro in the definition field. |
zen is the art of being at one with the two'ness |
|
|
|
sean
Whole Tomato Software
USA
2817 Posts |
Posted - Apr 10 2008 : 3:28:05 PM
|
The coloring of PostMessage will be addressed in the next beta:
case=15379 |
|
|
|
SvenR
Tomato Guru
110 Posts |
Posted - Apr 10 2008 : 4:12:47 PM
|
1626 doesn't have this Vista specific effect, even if it is used under Vista. I would like to have the 1626 design back in next beta (optionally). I made the experience that the 1626 listbox is better to read than the 1632/vc9 implementation, because my eyes are more focussed on the thick frame than on the items in the listbox.
PostMessage is defined as macro because it maps to PostMessageA/PostMessageW dependent on UNICODE switch. The same applies to all A/W functions and A/W structures. NMHEADER is defined as
typedef struct tagNMHEADERA
{
NMHDR hdr;
int iItem;
int iButton;
HDITEMA *pitem;
} NMHEADERA, *LPNMHEADERA;
typedef struct tagNMHEADERW
{
NMHDR hdr;
int iItem;
int iButton;
HDITEMW *pitem;
} NMHEADERW, *LPNMHEADERW;
#ifdef UNICODE
#define NMHEADER NMHEADERW
#define LPNMHEADER LPNMHEADERW
#else
#define NMHEADER NMHEADERA
#define LPNMHEADER LPNMHEADERA
#endif
So NMHEADER is defined as macro, but it is really a structure. 1626 shows NMHEADER as structure, but 1632 shows it as macro. Technically 1632 is right, but the Windows API contains a lot of such #defines and it would be very helpful if VA continue displaying these as structures/functions as in 1626. |
Windows 11 x64, VS 2022, VaX 10.9.2530 |
|
|
|
feline
Whole Tomato Software
United Kingdom
19022 Posts |
Posted - Apr 10 2008 : 4:24:16 PM
|
case=15379 should cover these colouring changes, and is fixed in the next build.
The listbox border is a different question, and I have asked internally about this. |
zen is the art of being at one with the two'ness |
|
|
|
kevinsikes
Tomato Guru
USA
271 Posts |
Posted - Apr 14 2008 : 6:24:21 PM
|
SvenR,
An upcoming build will allow you to choose Vista's listbox style or the original style. Thanks for the suggestion.
case=15898 |
Kevin Sikes
Infotainment Platform Design Engineer
Ford Motor Company |
|
|
|
SvenR
Tomato Guru
110 Posts |
Posted - Apr 15 2008 : 09:42:37 AM
|
Kevin, thanks for implementing.  |
Windows 11 x64, VS 2022, VaX 10.9.2530 |
|
|
|
support
Whole Tomato Software
5566 Posts |
Posted - Apr 24 2008 : 12:43:04 AM
|
case=15898 is implemented in build 1635
This setting is controlled via the registry:
HKEY_CURRENT_USER\\Software\\Whole Tomato\\Visual Assist X\\VANet8
[REG_DWORD] ListboxFlags = 0 (default - render with Vista style)
Set to 2 to render listboxes with a thin border.
1 is a reserved value. Other bitwise values may be added in future builds.
Replace "VANet8" with your IDE as appropriate. |
|
|
|
SvenR
Tomato Guru
110 Posts |
Posted - May 23 2008 : 04:18:17 AM
|
1639 marks LPCSTR as macro, 1626 doesn't. Alt-G shows the following list:
ole.h:31 #define LPCSTR LPSTR
wtypes.h:222 typedef __RPC_string const CHAR *LPCSTR;
winnt.h:407 typedef __nullterminated CONST CHAR *LPCSTR, *PCSTR;
It seems that the last included .h file is the winner. Is it possible to use the first definition for coloring?
PS: Thanks for thin listboxes.
|
Windows 11 x64, VS 2022, VaX 10.9.2530 |
|
|
|
feline
Whole Tomato Software
United Kingdom
19022 Posts |
Posted - May 23 2008 : 10:32:23 AM
|
I am seeing the same effect here. Thank you for the clear description.
case=16985
I see the same three items on alt-g in both versions of VA, but they are in a different order. I am not sure if that is a factor or not, but I mentioned it on the bug report just in case
I am glad you like the thin listbox edges I am not a fan of the Vista look either, but I do see how visual consistency is a good thing. This way everyone can be happy |
zen is the art of being at one with the two'ness |
Edited by - feline on May 23 2008 10:33:28 AM |
|
|
|
SvenR
Tomato Guru
110 Posts |
Posted - May 23 2008 : 5:44:24 PM
|
| With "last included .h file" I meant the order in which the files are included. ole.h is probably the last one and it overwrites wtypes.h and winnt.h (winnt.h is one of the first files that are included in windows.h). |
Windows 11 x64, VS 2022, VaX 10.9.2530 |
|
|
| |
Topic |
|
1632: Different colors and framed listboxes
