| T O P I C R E V I E W |
| accord |
Posted - Nov 14 2007 : 09:43:40 AM
C++, VS 2005 SP1
I used change signature to change the name of a function parameter (in a cpp file). I had a similar string in a comment, in my previous function body, and VAX renamed it also.
It is very important to disable find references' find comments and strings feature when change signature invokes rename (which invokes the find references)
I hope it will be very high priority bug 
|
| 6 L A T E S T R E P L I E S (Newest First) |
| feline |
Posted - Nov 22 2007 : 10:25:06 AM
That is our longer term plan. |
| hotzenplotz |
Posted - Nov 22 2007 : 08:49:12 AM
Maybe pop up the rename dialog if and only if any matches are found in comments and/or string? |
| sean |
Posted - Nov 15 2007 : 9:35:44 PM
case=9930 is fixed in build 1618 (restored to old behavior) |
| feline |
Posted - Nov 15 2007 : 08:41:05 AM
We are looking for a quick fix for these reasons and leaning towards the rename dialog appearing longer term.
Defining the "attached" comment can get interesting though, I thought up some interesting test cases when testing rename and comments. Overloaded functions was a good way to produce interesting effects. |
| accord |
Posted - Nov 14 2007 : 3:53:36 PM
quote:
I am just not sure of the best solution.
Rename should only search inside affected function's body and comments prior to function header.
But one thing is a little problematic: while rename populate a listbox with found comments, change signature's rename feature is working automatically. Automatically renaming comments is not a safe thing
Change signature should allways pop up the rename dialog before renaming, or when there are comments in the result at least. This idea is absolutely great in rename dialog!
Ps.: Maybe turning off "comments rename" in change signature as a hotfix?
|
| feline |
Posted - Nov 14 2007 : 1:50:18 PM
There is certainly a problem here, I am just not sure of the best solution. Renaming the correct comments is good if your function is commented.
case=9930 |
